Drupal "Blog this" bookmarklet v2.0 (ish)

My earlier bookmarklet spawned a fair bit of activity. Yay me! It has also been reworked by Valerie to make it more suitable for her purposes, and she's got it working properly with 'unclean' URLs. Nice one, Drupal community!

However, I found a problem the other day - if a webpage's title has a pipe character in it, attempting to 'Blog This' causes an 'internal server error'. It's something to do with pipes being used to move data between processes on Unix-like operating systems, I expect. They appear perfectly when you're typing away, but if they're involved with hyperlinks (like I've used to head up the blockquote section), everything fails ungracefully.

My solution is to use Javascript's replace function to replace any occurance of the pipe in the title with a double colon instead, so "Blah Blah | The Register" becomes "Blah Blah :: The Register". It works well so far! If you fancy a tinker, just update this section of the Javascript in the bookmarklet.

Here's the code, once again for peer review =) I've not added Valerie's modification for unclean URLs because it uses 'story' instead of 'blogs' and, having clean URLs working, it's hard for me to test and verify. That said, I've tried it and it seems a fine base for tinkering with. If you need the unclean URL support, head over to Valerie's website.

javascript:
u=document.location.href;
t=document.title.replace(/\|/g,'::');
s='<blockquote>'+window.getSelection()+'</blockquote>';
pre='<em>From <a target="_blank" href="'+escape(u)+'">'+escape(t) + escape('</a>:</em><br /> ');
void(window.open('http://www.example.com/node/add/blog?edit[title]='+escape('Link: '+t)+'&edit[body]='+pre+escape(s)+escape('<a href="'+u+'" target="_blank">Link</a>'),'_blank','width=710,height=500,status=yes,resizable=yes,scrollbars=yes'));

I'd like to be able to offer you a bookmarklet ready to drag to the links bar, but here's the deal: I can't. There's a pipe character in there, and as mentioned before, this breaks things when in links. The best I can do is offer you the code, as above, on one long line to make copying and pasting into a bookmark's properties a whole lot easier.

javascript: u=document.location.href; t=document.title.replace(/\|/g,'::'); s='<blockquote>'+window.getSelection()+'</blockquote>'; pre='<em>From <a target="_blank" href="'+escape(u)+'">'+escape(t) + escape('</a>:</em><br /> '); void(window.open('http://www.example.com/node/add/blog?edit[title]='+escape('Link: '+t)+'&edit[body]='+pre+escape(s)+escape('<a href="'+u+'" target="_blank">Link</a>'),'_blank','width=710,height=500,status=yes,resizable=yes,scrollbars=yes'));

Once again I remind you to change www.example.com to the correct address for your Drupal website, and other caveats noted before still apply.

Thanks everybody for trying this out, and I welcome any and all feedback - working together makes us more rocking (or something).